Search found 34 matches

by theonlylawislove
Fri, 2021-03-12, 22:40
Forum: DCMTK - General
Topic: My client-side DCMTK TLS code broke after upgrading to 3.6.4.
Replies: 5
Views: 3969

My client-side DCMTK TLS code broke after upgrading to 3.6.4.

Full details, repro, and logs, can be found here: https://github.com/pauldotknopf/dcmtk-tls-issue These commands don't work as of 3.6.4, and they did previously: storescp --log-level trace --enable-tls /work/domain.key /work/domain.crt -ic 104 echoscu +tla -ic localhost 104 When running those comman...
by theonlylawislove
Mon, 2020-06-15, 06:44
Forum: DCMTK - General
Topic: createValueFromTempFile with padding byte
Replies: 6
Views: 5648

Re: createValueFromTempFile with padding byte

Would you guys accept a PR? This seems like a trivial fix.
by theonlylawislove
Thu, 2018-06-28, 20:22
Forum: DCMTK - General
Topic: Memory leak with DcmSCPPool<>
Replies: 4
Views: 3226

Re: Memory leak with DcmSCPPool<>

My team has implemented the fix.

https://github.com/MedXChange/dcmtk/com ... 6b52bfa2d3

Can we get this upstream?
by theonlylawislove
Thu, 2018-06-28, 17:44
Forum: DCMTK - General
Topic: Memory leak with DcmSCPPool<>
Replies: 4
Views: 3226

Re: Memory leak with DcmSCPPool<>

Actually, I found a better solution. Here is my actual problem: https://stackoverflow.com/questions/17642433/why-pthread-causes-a-memory-leak You can fire-and-forgot pthreads, but you must call pthread_detatch after creating it. I suggest adding a OFThread::detach() method that callers can use if th...
by theonlylawislove
Thu, 2018-06-28, 16:12
Forum: DCMTK - General
Topic: Memory leak with DcmSCPPool<>
Replies: 4
Views: 3226

Memory leak with DcmSCPPool<>

I while back, I identified a memory leak in DcmSCPPool. Here was that thread for more information: https://forum.dcmtk.org/viewtopic.php?f=1&t=4534 For other reasons, I was forced to dig in and figure out that leak, and I have identified the cause. The problem is that when you do pthread_create,...
by theonlylawislove
Thu, 2017-07-13, 18:53
Forum: DCMTK - General
Topic: Working on automated Windows builds. Support libraries?
Replies: 1
Views: 2153

Working on automated Windows builds. Support libraries?

I plan on implementing continuous builds, based off of new commits of DCMTK. To do so, I need a stable snapshot of every support library. I made a repo to build all the support libraries for win32 and win64. It uses Docker, so it is very repeatable. Here is my first release. https://github.com/pauld...
by theonlylawislove
Tue, 2017-03-28, 14:30
Forum: DCMTK - General
Topic: Extracting 4G pixel data to file (raw) without loading...
Replies: 8
Views: 7860

Re: Extracting 4G pixel data to file (raw) without loading..

It fails because the pixel data element doesn't have the internal fLoadValue used to access the file again.
by theonlylawislove
Tue, 2017-03-28, 14:29
Forum: DCMTK - General
Topic: Extracting 4G pixel data to file (raw) without loading...
Replies: 8
Views: 7860

Re: Extracting 4G pixel data to file (raw) without loading..

The DcmWriteCache simply calls getPartialValue. That is pretty much all it does on "fill".

getPartialValue is returning the error.

If I replace DcmWriteCache with a direct getPartialValue, the error still persists.
by theonlylawislove
Mon, 2017-03-27, 21:52
Forum: DCMTK - General
Topic: Extracting 4G pixel data to file (raw) without loading...
Replies: 8
Views: 7860

Re: Extracting 4G pixel data to file (raw) without loading..

This is the simplest example, and I am getting the same issue. DcmFileFormat* fileFormat = new DcmFileFormat(); OFCondition cond = fileFormat->loadFile("/home/pknopf/git/medxchange.dicom/dcmfile.dcm"); DcmDataset* dataset = fileFormat->getDataset(); DcmElement* element = NULL; cond = datas...
by theonlylawislove
Mon, 2017-03-27, 19:51
Forum: DCMTK - General
Topic: Extracting 4G pixel data to file (raw) without loading...
Replies: 8
Views: 7860

Re: Extracting 4G pixel data to file (raw) without loading..

I am trying to refer to source to complete this the best I can, but I am stuck. I am loading a simple dataset (without loading it all into memory). DcmDataset* ds = new DcmDataset(); ds->loadFile("test.dcm"); Then, I get the DCM_PixelData element, and attempt to perform this loop. DcmXfer ...
by theonlylawislove
Mon, 2017-03-27, 16:35
Forum: DCMTK - General
Topic: Extracting 4G pixel data to file (raw) without loading...
Replies: 8
Views: 7860

Extracting 4G pixel data to file (raw) without loading...

...all data into memory?

I am implementing a STORE-SCP. I save the dicom file directly to disk, to be processed later.

Later, I need to extract that raw pixel data. How do I do this without loading all 4GB's of pixel data into memory?
by theonlylawislove
Mon, 2017-03-13, 01:20
Forum: DCMTK - General
Topic: scp.h with SSL
Replies: 1
Views: 2143

scp.h with SSL

I see scp.h is a common base class, used for many scp provider implementations (storage, find, etc) in the dcmtk. However, I don't see any way to configure openssl with the class. I could probably override "waitForAssocaition", and set the transport layer once, but that seems like a hack f...
by theonlylawislove
Sat, 2017-03-11, 22:26
Forum: DCMTK - General
Topic: Using extern C for some C-compatible methods
Replies: 1
Views: 2244

Using extern C for some C-compatible methods

I am working on an interop library so that dcmtk may be used in managed languages (C#, etc). With that said, I initially looked at wrapper scp.h, and a few others, but it seems that all these higher-level C++ classes just wrap lower-level C-like methods. http://git.dcmtk.org/?p=dcmtk.git;a=blob_plai...
by theonlylawislove
Sat, 2017-03-11, 22:16
Forum: DCMTK - General
Topic: Memory leak with simple DcmSCPPool
Replies: 8
Views: 8331

Re: Memory leak with simple DcmSCPPool

Since you are referring to a copy of DCMTK on github: Please use the original sources not the one from the commontk project I should have clarified. I am using dcmtk at this location: git clone git://git.dcmtk.org/dcmtk.git cd dcmtk git checkout DCMTK-3.6.1_20170228 I only referenced to github, bec...
by theonlylawislove
Mon, 2017-03-06, 22:37
Forum: DCMTK - General
Topic: Memory leak with simple DcmSCPPool
Replies: 8
Views: 8331

Re: Memory leak with simple DcmSCPPool

When the association stops, it doesn't seem to add the current worker thread to the list of idle threads.

https://github.com/commontk/DCMTK/blob/ ... ol.cc#L274