Bad Style?

[Marcel]

Dear Office Developers

Found uggly stuff in 3.6.x:
#include "../../dcmdata/apps/dcmgpdir.cc"
in file dcmmkdir.cc and maybe others.

While I'm used to find good to excellent software quality within dcmtk for years now stuff like this does not really fit

Beside quality issues this jeopardizes poor windoze builders using the WinOffice cc->cxx converter.

Kind regards
Marcel

[Jörg Riesmeier]

I agree that this is "bad style" but this has been introduced to dcmgpdir and dcm2pnm mainly for historical reasons: dcmmkdir and dcmj2pnm, which were introduced later, require JPEG support and, therefore, need to be linked to the libraries from dcmjpeg.

Beside quality issues this jeopardizes poor windoze builders using the WinOffice cc->cxx converter.

... and that's the reason why there is a more sophisticated shell script for this purpose: config/changext

Btw, changing the file extension is only necessary for the old Visual C++ 6.0 compiler (from 1998?), as far as I remember. And, there is also a registry entry that could be modified for this purpose.