ConfigurationWatchDogThread constructor wrong in config.cc

[chaircrusher]

Clang's complaint:

Code: Select all

dcmtk/oflog/libsrc/config.cc:561:22: warning: field is uninitialized when used here [-Wuninitialized] 
        , waitMillis(waitMillis < 1000 ? 1000 : millis)
                     ^
1 warning generated.

This constructor tries to test the value of a member variable in the course of initializing it. This makes no sense; at constructor time the member variable is GUARANTEED to be uninitialized:

Code: Select all

    ConfigurationWatchDogThread(const tstring& file, unsigned int millis)
        : PropertyConfigurator(file)
        , waitMillis(waitMillis < 1000 ? 1000 : millis)
        , shouldTerminate(false)
        , lock(NULL)
    { }

The net effect is that the one place an instance of ConfigurationWatchDogThread is created, it will get a wait time of 1000 milleseconds, or the specified time, depending on the value of uninitialized memory.

[J. Riesmeier]

Thank you for the report. This issue is now fixed.