DICOM @ OFFIS

Discussion Forum for OFFIS DICOM Tools - For registration, send email with desired user name to the OFFIS DICOM team
It is currently Fri, 2018-01-19, 20:38

All times are UTC + 1 hour




Post new topic Reply to topic  [ 3 posts ] 
Author Message
PostPosted: Wed, 2017-09-06, 13:17 
Offline

Joined: Fri, 2006-09-15, 09:25
Posts: 32
Location: Bulgaria
Hello,
I noticed one small problem when I use dcmtk 3.6.2
There is a commit from Apr 25, 2016 about NOMINMAX, but I noticed in file dcmtk/ofstd/oflimits.h there are 3 uses of numeric_limits<>::max that have to be (numeric_limits<>::max)

template<typename T>
struct OFnumeric_limits : std::numeric_limits<T>
{
static const int max_digits10 = 0;
static inline T lowest() { return (std::numeric_limits<T>::min)(); }
};
template<>
struct OFnumeric_limits<float> : std::numeric_limits<float>
{
static const int max_digits10 = DCMTK_FLOAT_MAX_DIGITS10;
static inline float lowest() { return -(std::numeric_limits<float>::max)(); }
};
template<>
struct OFnumeric_limits<double> : std::numeric_limits<double>
{
static const int max_digits10 = DCMTK_DOUBLE_MAX_DIGITS10;
static inline double lowest() { return -(std::numeric_limits<double>::max)(); }
};

_________________
Simeon Antonov


Last edited by simeon on Thu, 2017-09-07, 23:30, edited 1 time in total.

Top
 Profile  
 
PostPosted: Wed, 2017-09-06, 15:47 
Offline
DCMTK Developer

Joined: Tue, 2011-05-03, 14:38
Posts: 1889
Location: Oldenburg, Germany
Thank you for the report. This issue has already been fixed: http://git.dcmtk.org/?p=dcmtk.git;a=com ... 2b741dc01b


Top
 Profile  
 
PostPosted: Thu, 2017-09-07, 23:31 
Offline

Joined: Fri, 2006-09-15, 09:25
Posts: 32
Location: Bulgaria
Thanks.

_________________
Simeon Antonov


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 3 posts ] 

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group