bug in DcmPixelData::hasRepresentation ?

[Roelant]

I had some unexpected behaviour of my software which may be caused by a bug in DcmPixelData::hasRepresentation:

DcmPixelData::hasRepresentation checks if an appropriate representation of the pixel data is available. However, since DcmPixelData::findConformingEncapsulatedRepresentation returns either EC_Normal or EC_RepresentationNotFound

the code (in DcmPixelData::hasRepresentation):

Code: Select all

else if (repTypeSyn.isEncapsulated())
        return findConformingEncapsulatedRepresentation(
            repTypeSyn, repParam, found) != EC_Normal;

will return TRUE if an encapsulated representation is not available (!=EC_Normal) while required.

Best regards,
Roelant.

[Marco Eichelberg]

This looks like a bug indeed. It seems that DcmPixelData::hasRepresentation is not used anywhere in the toolkit (except for DcmDataset::hasRepresentation, which is not used anywhere either), so this bug may very well never have surfaced. If changing the code (replacing the "!= EC_Normal" by ".good()" ) fixes your application, please let me know and I will also fix this in our code repository.