Search found 131 matches

by Shaeto
Tue, 2020-06-30, 13:32
Forum: DCMTK - General
Topic: bug in the DcmElement::writeJsonOpener
Replies: 1
Views: 82

bug in the DcmElement::writeJsonOpener

from DICOM PS3.18 F.2.2 DICOM JSON Model Object Structure The name of each attribute object is: The eight character uppercase hexadecimal representation of a DICOM Tag but in DcmElement::writeJsonOpener /* write attribute tag */ out << ++format.indent() << "\"" << STD_NAMESPACE hex << STD_NAMESPACE ...
by Shaeto
Wed, 2019-06-12, 12:55
Forum: DCMTK - General
Topic: support for fractional part of a second
Replies: 1
Views: 538

support for fractional part of a second

github is a mirror, so, i am not sure you see pull requests notifications

may be useful patch for dcmtk: https://github.com/DCMTK/dcmtk/pull/17
by Shaeto
Mon, 2019-02-18, 10:53
Forum: DCMTK - Installation
Topic: fc28/rh8 libiconv again
Replies: 5
Views: 1202

Re: fc28/rh8 libiconv again

3rdparty.cmake: message(STATUS "Warning: ICONV support will be disabled because libiconv was not found. Correct LIBICONV_LIBDIR and LIBICONV_INCLUDE_DIR and re-enable DCMTK_WITH_ICONV.")
by Shaeto
Mon, 2019-02-18, 10:26
Forum: DCMTK - Installation
Topic: fc28/rh8 libiconv again
Replies: 5
Views: 1202

Re: fc28/rh8 libiconv again

yes, it is latest but still problem i can compile and build using libiconv under rh8 if use cmake \ ........ -DIconv_INCLUDE_DIR:STRING="/usr/libiconv/include" \ -DIconv_LIBRARY:STRING="/usr/libiconv/lib64/libiconv.so" \ instead of recommended LIBICONV_INCLUDE_DIR and LIBICONV_LIBDIR/LIBICONV_LIBRARY
by Shaeto
Fri, 2019-02-08, 16:18
Forum: DCMTK - Installation
Topic: fc28/rh8 libiconv again
Replies: 5
Views: 1202

fc28/rh8 libiconv again

Hi, in fedora 28 and incoming RH8 cmake provides own FindIconv.cmake module and LIBICONV_LIBDIR/DLIBICONV_INCLUDE_DIR variables do not work there, thats okay if libiconv is in standard paths but it is not - libiconv rpm installs it to /usr/libiconv, so, we need standard way to provide paths
by Shaeto
Thu, 2018-03-29, 17:52
Forum: DCMTK - General
Topic: bug in poll/connect
Replies: 2
Views: 1021

bug in poll/connect

Hi, there is an important request on github (not my)

https://github.com/DCMTK/dcmtk/pull/3

i am not sure about changes for dcmtrans.cc but POLLIN in dcmfsm.cc is very serious issue, 3.6.3 release is not usable under linux because of poll(..POLLIN...) after connect(), it should be POLLOUT

Thanks!
by Shaeto
Thu, 2017-06-01, 14:42
Forum: DCMTK - General
Topic: character encoding
Replies: 12
Views: 7734

Re: character encoding

moderm linux distros do not provide classical libiconv, it is available only as a part of glibc, you know glibc variant is not so powerful as a "standard" lib so... i thought libicu is more convenient as it supported by my distro and dcmtk btw as i understand libicu supports "dicom" esc code switche...
by Shaeto
Wed, 2017-05-31, 01:15
Forum: DCMTK - General
Topic: character encoding
Replies: 12
Views: 7734

Re: character encoding

btw, is it possible to fix dicom->libicu character set mapping ? here is a good documents http://demo.icu-project.org/icu-bin/convexp and https://en.wikipedia.org/wiki/ISO/IEC_2022 i suggest to use: japanese: ISO_IR 13 -> ISO-2022-JP (and ISO_IR 14 -> ISO-2022-JP ?) ISO 2022 IR 87 -> ISO-2022-JP ISO...
by Shaeto
Tue, 2017-05-30, 22:13
Forum: DCMTK - General
Topic: character encoding
Replies: 12
Views: 7734

Re: character encoding

well... you confirmed the most terrible assumptions - modality software developers do not read standard :( this year we started to receive studies with (0008, 0005) VM =1 and ISO 2022 IR 87 and other extensions, I was hoping that the standard could explain this.
by Shaeto
Fri, 2017-05-26, 19:04
Forum: DCMTK - General
Topic: character encoding
Replies: 12
Views: 7734

character encoding

not sure if i correct understand dicom 2016 but http://dicom.nema.org/medical/dicom/2016d/output/chtml/part02/sect_D.6.2.html does this mean what 0008,0005 can contain "ISO 2022 IR 100" with VM 1 ? in this case DcmSpecificCharacterSet class should allow "ISO 2022 IR 100" VM 1 but actually it does no...
by Shaeto
Fri, 2017-04-14, 15:25
Forum: DCMTK - General
Topic: bug in OFTime::setISOFormattedTime
Replies: 1
Views: 1086

bug in OFTime::setISOFormattedTime

lines: if (sscanf(formattedTime.c_str(), "%02u%02u%02u %03i %02u", &hours, &minutes, &seconds, &tzHours, &tzMinutes) == 5) and if (sscanf(formattedTime.c_str() + pos - 1, " %03i %*c%02u", &tzHours, &tzMinutes) == 2) according to manuals: %i: Defaults to base 10 integers. Data starting with 0 is read...
by Shaeto
Tue, 2017-02-21, 13:02
Forum: DCMTK - General
Topic: DcItem::newDicomElement for private tags
Replies: 4
Views: 2313

Re: DcItem::newDicomElement for private tags

cant attach file to this forum please download .patch from https://ufile.io/e1448

thanks!
by Shaeto
Tue, 2017-02-21, 10:51
Forum: DCMTK - General
Topic: DcItem::newDicomElement for private tags
Replies: 4
Views: 2313

DcItem::newDicomElement for private tags

is it possible to add privateCreator parameter for 2 static methods DcmItem::newDicomElement ? for example static DcmElement *newDicomElement(const DcmTagKey &tag, const char *privateCreator = NULL) .... { DcmTag temp(tag, privateCreator); .... currently it is not possible to use this method to crea...
by Shaeto
Thu, 2016-12-22, 10:32
Forum: DCMTK - General
Topic: autoconf
Replies: 2
Views: 1397

autoconf

hi, i have noticed that Makefile.in (master) lib deps for some subprojects does not contain rule updates for new source files, for example fgparametricmapframetype.o, fgframeanatomy.o etc do you have plans to get rid of autoconf and switch to cmake only ? update: in dcmpmap/libsrc/Makefile.in dpmtyp...
by Shaeto
Wed, 2016-07-20, 14:58
Forum: DCMTK - General
Topic: ofthread test
Replies: 4
Views: 3069

Re: ofthread test

np, thank you for the perfect framework,

btw if someone is interesting i (re-)implemented OFSemaphore on Mac OS El Capitan using c++11 mutex/condition_variable classes

not sure how to attach files to board now