Search found 140 matches

by Shaeto
Fri, 2021-04-02, 13:38
Forum: DCMTK - General
Topic: dcmjpeg encoder crashes on EPI_YBR_RCT and EPI_YBR_ICT
Replies: 10
Views: 284

Re: dcmjpeg encoder crashes on EPI_YBR_RCT and EPI_YBR_ICT

Okay thank you i will modify our fork,

last question is -Wall for cxx flags in cmake configuration
by Shaeto
Fri, 2021-04-02, 13:05
Forum: DCMTK - General
Topic: dcmjpeg encoder crashes on EPI_YBR_RCT and EPI_YBR_ICT
Replies: 10
Views: 284

Re: dcmjpeg encoder crashes on EPI_YBR_RCT and EPI_YBR_ICT

yes i use a fork of master but seems it is modified to support jpeg-2000 classes in dcmimgle/include/dcmtk/dcmimgle/diutils.h we added const SP_Interpretation PhotometricInterpretationNames[] = ..... {"YBRICT", "YBR_ICT", EPI_YBR_ICT}, {"YBRRCT", "YBR_RCT", EPI_YBR_RCT}, {"YUVRCT", "YUV_RCT", EPI_YB...
by Shaeto
Fri, 2021-04-02, 10:57
Forum: DCMTK - General
Topic: dcmjpeg encoder crashes on EPI_YBR_RCT and EPI_YBR_ICT
Replies: 10
Views: 284

Re: dcmjpeg encoder crashes on EPI_YBR_RCT and EPI_YBR_ICT

YBR_RCT, YBR_ICT and YBR_PARTIAL_420 make no sense for uncompressed images. agree! but can't change this world - wrong dicom is came Anyway, where does the crash happen? it crashed in dcmdata/libsrc/dcpixel.cc:1195 1195 return (*current)->pixSeq->loadAllDataIntoMemory(); pixSeq is null (because of ...
by Shaeto
Fri, 2021-04-02, 09:25
Forum: DCMTK - General
Topic: dcmjpeg encoder crashes on EPI_YBR_RCT and EPI_YBR_ICT
Replies: 10
Views: 284

Re: dcmjpeg encoder crashes on EPI_YBR_RCT and EPI_YBR_ICT

i tested this case using master I understand what YBR_RCT​ and YBR_ICT are only allowed for compressed images but it seems not all developers understand it also, so, our equipment sometime receives such dicoms from some "client tele-medical environment" it seems CMAKE_CXX_FLAGS is lack of -Wall that...
by Shaeto
Thu, 2021-04-01, 20:53
Forum: DCMTK - General
Topic: dcmjpeg encoder crashes on EPI_YBR_RCT and EPI_YBR_ICT
Replies: 10
Views: 284

dcmjpeg encoder crashes on EPI_YBR_RCT and EPI_YBR_ICT

switch (photometricInterpretation) in dcmjpeg/libsrc/djcodece.cc: DJCodecEncoder::encode does not catch EPI_YBR_RCT and EPI_YBR_ICT and there is no default:, so, it produces wrong Pixel Representation context with NULL pixel sequence how to reproduce : get or create 8 bits image dicom having (0028,0...
by Shaeto
Thu, 2021-01-28, 10:34
Forum: DCMTK - General
Topic: bug in DcmFileFormat::writeJson
Replies: 2
Views: 239

bug in DcmFileFormat::writeJson

version 3.6.6 (and master) method DcmFileFormat::writeJson does not print "," between meta and main dataset i used simplest fix (didn't want to use stringstream) if (dset && status.good()) { if (metinf && metinf->card()) out << ","; status = dset->writeJsonExt(out, format, OFFalse, OFFalse); } thanks!
by Shaeto
Thu, 2020-08-06, 14:29
Forum: DCMTK - General
Topic: Bug in DcmPersonName::writeJson
Replies: 4
Views: 595

Re: Bug in DcmPersonName::writeJson

Yes i meant the native model (dcm2xml -nat)
by Shaeto
Thu, 2020-08-06, 11:23
Forum: DCMTK - General
Topic: Bug in DcmPersonName::writeJson
Replies: 4
Views: 595

Re: Bug in DcmPersonName::writeJson

Thank you Michael,

I see the same problem in DcmPersonName::writeXML method, the writer does not encode components of the patient name
by Shaeto
Wed, 2020-08-05, 10:59
Forum: DCMTK - General
Topic: Bug in DcmPersonName::writeJson
Replies: 4
Views: 595

Bug in DcmPersonName::writeJson

method DcmPersonName::writeJson outputs incorrectly encoded data to the json document

"Lexer" helper class does not encode characters and produces invalid json if patient name contains for example " (quotation mark)

imho Lexer::writeComponent must call something like DcmJsonFormat::printValueString
by Shaeto
Tue, 2020-06-30, 13:32
Forum: DCMTK - General
Topic: bug in the DcmElement::writeJsonOpener
Replies: 1
Views: 353

bug in the DcmElement::writeJsonOpener

from DICOM PS3.18 F.2.2 DICOM JSON Model Object Structure The name of each attribute object is: The eight character uppercase hexadecimal representation of a DICOM Tag but in DcmElement::writeJsonOpener /* write attribute tag */ out << ++format.indent() << "\"" << STD_NAMESPACE hex << STD_NAMESPACE ...
by Shaeto
Wed, 2019-06-12, 12:55
Forum: DCMTK - General
Topic: support for fractional part of a second
Replies: 1
Views: 795

support for fractional part of a second

github is a mirror, so, i am not sure you see pull requests notifications

may be useful patch for dcmtk: https://github.com/DCMTK/dcmtk/pull/17
by Shaeto
Mon, 2019-02-18, 10:53
Forum: DCMTK - Installation
Topic: fc28/rh8 libiconv again
Replies: 5
Views: 1838

Re: fc28/rh8 libiconv again

3rdparty.cmake: message(STATUS "Warning: ICONV support will be disabled because libiconv was not found. Correct LIBICONV_LIBDIR and LIBICONV_INCLUDE_DIR and re-enable DCMTK_WITH_ICONV.")
by Shaeto
Mon, 2019-02-18, 10:26
Forum: DCMTK - Installation
Topic: fc28/rh8 libiconv again
Replies: 5
Views: 1838

Re: fc28/rh8 libiconv again

yes, it is latest but still problem i can compile and build using libiconv under rh8 if use cmake \ ........ -DIconv_INCLUDE_DIR:STRING="/usr/libiconv/include" \ -DIconv_LIBRARY:STRING="/usr/libiconv/lib64/libiconv.so" \ instead of recommended LIBICONV_INCLUDE_DIR and LIBICONV_LIBDIR/LIBICONV_LIBRARY
by Shaeto
Fri, 2019-02-08, 16:18
Forum: DCMTK - Installation
Topic: fc28/rh8 libiconv again
Replies: 5
Views: 1838

fc28/rh8 libiconv again

Hi, in fedora 28 and incoming RH8 cmake provides own FindIconv.cmake module and LIBICONV_LIBDIR/DLIBICONV_INCLUDE_DIR variables do not work there, thats okay if libiconv is in standard paths but it is not - libiconv rpm installs it to /usr/libiconv, so, we need standard way to provide paths
by Shaeto
Thu, 2018-03-29, 17:52
Forum: DCMTK - General
Topic: bug in poll/connect
Replies: 2
Views: 1348

bug in poll/connect

Hi, there is an important request on github (not my)

https://github.com/DCMTK/dcmtk/pull/3

i am not sure about changes for dcmtrans.cc but POLLIN in dcmfsm.cc is very serious issue, 3.6.3 release is not usable under linux because of poll(..POLLIN...) after connect(), it should be POLLOUT

Thanks!