Search found 31 matches

by andreasb
Tue, 2024-06-11, 12:08
Forum: DCMTK - General
Topic: dcmPreferVRFromDataDictionary and EVR_ox
Replies: 12
Views: 7024

Re: dcmPreferVRFromDataDictionary and EVR_ox

Thanks, that's what I thought you meant, but I wasn't sure :)
I'll do my own patch then and will propose it to you later. BTW, what is the preferred way for this: posting the patch here, or making a PR in GitHub?
by andreasb
Tue, 2024-06-11, 11:57
Forum: DCMTK - General
Topic: dcmPreferVRFromDataDictionary and EVR_ox
Replies: 12
Views: 7024

Re: dcmPreferVRFromDataDictionary and EVR_ox

Thanks, I will have a look. Still not sure: do you mean that I call this in my own code, or that I patch dcmtk?
by andreasb
Mon, 2024-06-10, 21:14
Forum: DCMTK - General
Topic: dcmPreferVRFromDataDictionary and EVR_ox
Replies: 12
Views: 7024

Re: dcmPreferVRFromDataDictionary and EVR_ox

Thanks, Jörg! Sure, these would not solve all the problems, especially the second one, as I wrote. I thought that the first proposal (not "correcting" correct VRs to ambiguous VRs) would at least avoid the problem, even if it would not add a correction for these VRs. I don't see any advant...
by andreasb
Mon, 2024-06-10, 17:43
Forum: DCMTK - General
Topic: dcmPreferVRFromDataDictionary and EVR_ox
Replies: 12
Views: 7024

Re: dcmPreferVRFromDataDictionary and EVR_ox

To elaborate a bit more about the change I would like to have or make: The easiest way would be to just ignore these ambiguous VRs if dcmPreferVRFromDataDictionary is set, e.g. something like: if (dcmPreferVRFromDataDictionary.get() && (newEVR != EVR_UNKNOWN) && (newEVR != EVR_UNKNOW...
by andreasb
Mon, 2024-06-10, 16:14
Forum: DCMTK - General
Topic: dcmPreferVRFromDataDictionary and EVR_ox
Replies: 12
Views: 7024

Re: dcmPreferVRFromDataDictionary and EVR_ox

Thanks Marco! Yes, I understand that EVR_ox, EVR_xs etc. are used for ambiguous VRs. My problem is with the mentioned code in dcitem.cc , which resets the correct value for WaveformData (in this case OW ) back to EVR_ox , if dcmPreferVRFromDataDictionary is true. If I use either getUint16Array or ge...
by andreasb
Fri, 2024-06-07, 07:52
Forum: DCMTK - General
Topic: dcmPreferVRFromDataDictionary and EVR_ox
Replies: 12
Views: 7024

dcmPreferVRFromDataDictionary and EVR_ox

I'm not sure if this is expected behavior or a bug. I was setting dcmPreferVRFromDataDictionary to true to avoid common VR errors, and this works well for most tags, but I got a problem with waveform data, which has the VR OW, but was changed to EVR_ox due to that setting. If then trying to read the...
by andreasb
Mon, 2016-02-01, 12:58
Forum: DCMTK - General
Topic: dcmmkdir crash under Windows 8 32 bit (SOLVED)
Replies: 8
Views: 31686

Re: dcmmkdir crash under Windows 8 32 bit (SOLVED)

Thanks Jörg - that was fast!
- Andreas
by andreasb
Mon, 2016-02-01, 08:07
Forum: DCMTK - General
Topic: dcmmkdir crash under Windows 8 32 bit (SOLVED)
Replies: 8
Views: 31686

Re: dcmmkdir crash under Windows 8 32 bit (SOLVED)

You are welcome :)
Maybe it makes sense to incorporate this trivial fix into the trunk now, with Windows 10 out in the wild? Michael, Jörg, anyone?
by andreasb
Thu, 2015-08-13, 17:01
Forum: DCMTK - General
Topic: storescu fails to convert private pixel data
Replies: 2
Views: 24098

Re: storescu fails to convert private pixel data

Ah, thanks - I did not see this part.
And yes, we use ON_THE_FLY_COMPRESSION. If we send the data without compression there are no problems.

Thanks,
Andreas
by andreasb
Wed, 2015-08-12, 13:50
Forum: DCMTK - General
Topic: storescu fails to convert private pixel data
Replies: 2
Views: 24098

storescu fails to convert private pixel data

Hi, We have some data sets that storescu tries to convert to JPEG lossless as requested by the receiver, but fails due to some private sequence. The private sequence contains all tags needed to calculate the pixel data length, and a pixel data tag which contains much less data then expected, so the ...
by andreasb
Wed, 2015-08-12, 12:17
Forum: Other DICOM Tools
Topic: storescu crash with large JPEG Baseline coded dataset
Replies: 4
Views: 22635

Re: storescu crash with large JPEG Baseline coded dataset

I agree - I just didn't want to integrate the size_t changes into our 3.6.0 version at the moment. The check will be needed anyway for 32 bit platforms because size_t is still 32 bit there and the crash would occur anyway. On 64 bit platforms, the check will always succeed with the site_t approach, ...
by andreasb
Wed, 2015-08-12, 08:42
Forum: Other DICOM Tools
Topic: storescu crash with large JPEG Baseline coded dataset
Replies: 4
Views: 22635

Re: storescu crash with large JPEG Baseline coded dataset

The following prevents the crash (this is for the 3.6.0. version): Index: djcodecd.cc =================================================================== --- djcodecd.cc (revision 5186) +++ djcodecd.cc (working copy) @@ -152,21 +152,26 @@ { Uint32 frameSize = ((precision > 8) ? sizeof(Uint16) : size...
by andreasb
Wed, 2015-08-12, 07:35
Forum: Other DICOM Tools
Topic: storescu crash with large JPEG Baseline coded dataset
Replies: 4
Views: 22635

Re: storescu crash with large JPEG Baseline coded dataset

Ok, just looked into it a little more - the uncompressed size of the data set is more than 4GB, so it causes an integer overflow in the uncompressed size calculation in DJCodecDecoder::decode(). Thus the allocated memory for the decompressed data is too small, and the crash happens later in memcpy()...
by andreasb
Tue, 2015-08-11, 16:38
Forum: Other DICOM Tools
Topic: storescu crash with large JPEG Baseline coded dataset
Replies: 4
Views: 22635

storescu crash with large JPEG Baseline coded dataset

Hi, we use storescu 3.6.0 compiled with ON_THE_FLY_COMPRESSION under Windows 64 bit. With some specific large data sets (UltrasoundMultiframeImageStorage) encoded as JPEGBaseline (800x600 with over 3000 frames) storescu crashes during image decoding - looks like an access violation in memcpy(). Is t...