Search found 2524 matches

by J. Riesmeier
Thu, 2024-07-11, 14:00
Forum: DCMTK - General
Topic: Using ProcedureCodeSequence to query for studies
Replies: 3
Views: 254

Re: Using ProcedureCodeSequence to query for studies

Good luck, but most Attributes are not required to be supported by a Query/Retrieve SCP. See e.g. this table for "Study Level Keys for the Patient Root Query/Retrieve Information Model" -- only 5 of them are actually required to be supported.
by J. Riesmeier
Thu, 2024-07-11, 08:23
Forum: DCMTK - General
Topic: Using ProcedureCodeSequence to query for studies
Replies: 3
Views: 254

Re: Using ProcedureCodeSequence to query for studies

I guess that you use findscu as a command line tool. The so-called path syntax for nested elements is described in the documentation ( man page of this tool). Something like e.g. "-k ProcedureCodeSequence[0].CodeValue=CV -k ProcedureCodeSequence[0].CodingSchemeDesignator=CSD" should work, ...
by J. Riesmeier
Fri, 2024-06-28, 14:26
Forum: DCMTK - Installation
Topic: Vulnerabilities in OpenSSL 1.1.1w
Replies: 8
Views: 344

Re: Vulnerabilities in OpenSSL 1.1.1w

As I said, "support for OpenSSL 3.1 and 3.2 has been added in February this year, i.e. after the release of DCMTK 3.6.8 (see git log)". That means, if you want to use newer versions of OpenSSL, such as 3.1 or 3.2, this will only work with a newer version of the DCMTK, i.e. a non-release ve...
by J. Riesmeier
Fri, 2024-06-28, 09:20
Forum: DCMTK - Installation
Topic: Vulnerabilities in OpenSSL 1.1.1w
Replies: 8
Views: 344

Re: Vulnerabilities in OpenSSL 1.1.1w

Of course, there were changes after the release of version 3.6.8, and if you take a look at the current INSTALL file, there is actually a "warning" at the beginning: ------------------------------------------------------------------------------- IMPORTANT NOTE FOR CURRENT DEVELOPMENT VERSI...
by J. Riesmeier
Fri, 2024-06-28, 09:16
Forum: DCMTK - Installation
Topic: Changing version of OpenSSL for an already configured build system
Replies: 9
Views: 369

Re: Changing version of OpenSSL for an already configured build system

I would suggest that you delete the CMake cache before you re-configure, because during this process various features of the selected OpenSSL version are checked.
by J. Riesmeier
Wed, 2024-06-19, 10:46
Forum: DCMTK - General
Topic: dsr2xml drops milliseconds from SR content items of type DATETIME and TIME
Replies: 4
Views: 314

Re: dsr2xml drops milliseconds from SR content items of type DATETIME and TIME

I've just created a new entry to our issue tracker: Feature #1128: dcmsr should support the fractional part of a second in its own XML format Yes, this feature is currently blocked by issue #895 and #1127 . The patch from the GitHub pull request 17 is certainly a good starting point, but I will not ...
by J. Riesmeier
Tue, 2024-06-18, 16:44
Forum: DCMTK - General
Topic: dsr2xml drops milliseconds from SR content items of type DATETIME and TIME
Replies: 4
Views: 314

Re: dsr2xml drops milliseconds from SR content items of type DATETIME and TIME

I think there is at least no good reason for it. This is just the format that was implemented at that time. I guess it shouldn't be too complicated to change this (including the XML Schema). I'll have a look at this (as time permits)... P.S.: I just noticed that the reason for not supporting the fra...
by J. Riesmeier
Fri, 2024-06-14, 13:26
Forum: DCMTK - General
Topic: dcmPreferVRFromDataDictionary and EVR_ox
Replies: 12
Views: 558

Re: dcmPreferVRFromDataDictionary and EVR_ox

Fixed with commit 2b53c9d8d, which should be visible in the public git repository soon.

Also see GitHub PR 100.
by J. Riesmeier
Tue, 2024-06-11, 12:20
Forum: DCMTK - General
Topic: dcmPreferVRFromDataDictionary and EVR_ox
Replies: 12
Views: 558

Re: dcmPreferVRFromDataDictionary and EVR_ox

Unless the patch fixes a security issue (which is not the case here), it is up to you whether you want to submit the proposed patch by email (bugs/at/dcmtk/dot/org), here i the forum or as a PR at GitHub.
by J. Riesmeier
Tue, 2024-06-11, 12:01
Forum: DCMTK - General
Topic: dcmPreferVRFromDataDictionary and EVR_ox
Replies: 12
Views: 558

Re: dcmPreferVRFromDataDictionary and EVR_ox

As I wrote in a previous posting (see above), I would suggest to call this method within the DCMTK (i.e. somewhere in dcmdata). Whether you come up with a proposed patch or someone from the DCMTK team finds some time to do this depends on how urgent it is (for you) :wink:
by J. Riesmeier
Tue, 2024-06-11, 10:13
Forum: DCMTK - General
Topic: dcmPreferVRFromDataDictionary and EVR_ox
Replies: 12
Views: 558

Re: dcmPreferVRFromDataDictionary and EVR_ox

I haven't checked the code in detail, but intuitively I would suggest to use the existing method DcmItem::checkAndUpdateVR(), which updates the VR in a few special cases such as Waveform Data, and call it after reading a DICOM dataset if option dcmPreferVRFromDataDictionary is enabled. I think curre...
by J. Riesmeier
Mon, 2024-06-10, 20:59
Forum: DCMTK - General
Topic: dcmPreferVRFromDataDictionary and EVR_ox
Replies: 12
Views: 558

Re: dcmPreferVRFromDataDictionary and EVR_ox

Your proposed changes would not solve all issues, in particular as "ox" represents either a sequence of 8 or 16 bit values. I would suggest to check whether calling DcmItem::checkAndUpdateVR() at an appropriate location (i.e. within the DCMTK) would be a suitable solution.
by J. Riesmeier
Fri, 2024-05-24, 12:48
Forum: DCMTK - General
Topic: ECG modality (scu) does not find records in wlmscpfs (scp) when they exist
Replies: 11
Views: 1180

Re: ECG modality (scu) does not find records in wlmscpfs (scp) when they exist

When I compare some lines of the log output for the first (not working)... I: (0008,0060) CS [ECG] # 4, 1 Modality I: (0040,0001) AE [HPCHPSURG12E] # 12, 1 ScheduledStationAETitle I: (0040,0002) DA [20240523-20240524] # 18, 1 ScheduledProcedureStepStartDate I: (0040,0003) TM (no value available) # 0...
by J. Riesmeier
Fri, 2024-05-24, 09:14
Forum: DCMTK - General
Topic: Specific Character set issue
Replies: 11
Views: 1545

Re: Specific Character set issue

The Specific Character Set that is used for a C-FIND response dataset is specified by the SCP, if this was the question. You could check in the DICOM Conformance Statement of the particular device which character sets are supported and how they are used.
by J. Riesmeier
Fri, 2024-05-24, 09:10
Forum: DCMTK - General
Topic: ECG modality (scu) does not find records in wlmscpfs (scp) when they exist
Replies: 11
Views: 1180

Re: ECG modality (scu) does not find records in wlmscpfs (scp) when they exist

There is no problem with the Transfer Syntax, but there are simply no matches in your worklist "database" (see wlmscpfs's log output lines that end with "does not match query").