DICOM @ OFFIS

Confirming the problem is fixed e. g. in ef9173b95.

Thanks.

P. S.: I really think this forum should be accessible by HTTPS. Replacing the outdated certificate shouldn't be a problem any more due to Let's Encrypt.

Is LD_LIBRARY_PATH still commonly used these days in the first place? I've never seen it being set on any recent Linux distribution according to env and was hence assuming that the paths are detected by other means like /etc/ld.so.cache or CMake itself. That aside I had been expected /usr/local/lib ...

The failure to build against libiconv seems to correspond with the build environment. DCMTK 0bf28e1 compiles flawlessly against manually installed libiconv 1.14 on up-to-date Debian stretch (testing) here as well while on Arch Linux there's still the failure as depicted above (exept the error messag...

Regarding the paths I think both is right. The source code of the vast majority of projects defaults to installing in /usr/local which probably makes sense to avoid accidental interference with system-wide software. On the other hand software meant to be available system-wide should by no means go t...

Confirming the said warnings are gone both in 8a79ba8 and 0bf28e1. FWIW in both commits warnings like the following can be seen [ 21%] Building CXX object ofstd/tests/CMakeFiles/ofstd_tests.dir/tstring.cc.o /usr/local/peter/Tests/DCMTK/Projekt/dcmtk/oflog/libsrc/hierlock.cc: In destructor ‘dcmtk::lo...

J. Riesmeier wrote: ... and a typical Windows user will also never change the defaults (especially not advanced CMake variables, which are hidden by default)

This pretty much counteracts your own argument why those GNU variables should be avoided.

J. Riesmeier wrote: But isn't it version 1.14?

Sure, as said above meanwhile. Installed by AUR package libiconv, btw.

Could you please try to replace "_libiconv_version" with "_LIBICONV_VERSION"? Err, where? Replacing in ./ofstd/libsrc/ofchrenc.cc, apparently the only appearance of the string within the code of DCMTK, as per --- a/dcmtk/ofstd/libsrc/ofchrenc.cc 2016-11-07 12:34:08.791516213 +01...

The question whether the variable should optionally be renamed certainly isn't a crucial feature and a decision up to you devs. That said the Windows argument stated in the previous comment seems a bit odd. I figure to most "Windows users" string SYSCONFDIR will be more intuitive and meani...

As I just saw compiling against libiconv 1.14 seems to fail in addition: /usr/local/peter/Tests/DCMTK/Projekt/dcmtk/ofstd/libsrc/ofchrenc.cc:495:28: error: ‘_libiconv_version’ was not declared in this scope sprintf(buf, "%i.%i", (_libiconv_version >> 8), (_libiconv_version & 0xff)); ^~...

Grepping through the Arch Linux PKGBUILDS suggests SYSCONFDIR, <software>_INSTALL_SYSCONFDIR and CMAKE_INSTALL_SYSCONFDIR are rather commonly used. The latter is corresponding with CMake module GNUInstallDirs . If I'm not mistaken the variables covered by that module are not referring to the particu...

Regarding iconv() it seems DCMTK can only make use of libiconv and disables the feature when this particular library is missing as any attempt to make it use e. g. the implementation in glibc fails ending in messages like checking whether to include libiconv support... no checking whether the second...

Variable DCMTK_INSTALL_ETCDIR is listed both by 'cmake -LAH' and cmake-gui and doing the trick, the corresponding help text is explaining well what the variable is doing. I've only missed all this as I wasn't searching for the proper strings so basically this thread was dealing with a non-issue. Sor...

Confirming the problem can no longer be seen as of b7b5503. The fix does introduce some new warnings like /usr/local/peter/Tests/DCMTK/ArchLinux/dcmtk-git/src/dcmtk/ofstd/tests/tlimits.cc:61:63: warning: integer overflow in expression [-Woverflow] OFCHECK( OFstatic_cast( T, OFnumeric_limits<T>::max(...

not sure whether setting the installation prefix to /usr is often done by people that build DCMTK. I assume that it is more common to install DCMTK to /usr/local I respectfully disagree. Rather, DCMTK is meant to be used as a regular system library most of the time and as such installed to /usr/lib...