Search found 37 matches

by jogerh
Sun, 2022-12-04, 19:52
Forum: DCMTK - General
Topic: Any need for a schannel-based TLS layer for DCMTK?
Replies: 1
Views: 88

Any need for a schannel-based TLS layer for DCMTK?

Is there a need for secure communication using SChannel instead of OpenSSL in DCMTK on Windows? On the Windows platform, the OpenSSL library has two main issues: 1. OpenSSL is incompatible with secure key storage on TPM chips on the Windows platform. Having this capability would improve security in ...
by jogerh
Mon, 2022-10-10, 09:00
Forum: DCMTK - General
Topic: Compile problems on VS 2019
Replies: 1
Views: 160

Compile problems on VS 2019

Currently, I am unable to build dcmdata from the master branch on VS 2019 due to a seemingly missing include of Windows.h

See https://github.com/DCMTK/dcmtk/pull/72 for a fix.

In my setup I build with OpenSSL and ICU. Not sure if this has anything to do with it.
by jogerh
Wed, 2022-10-05, 14:13
Forum: DCMTK - General
Topic: How to populate request MessageId when deriving from DcmScu
Replies: 35
Views: 4747

Re: How to populate request MessageId when deriving from DcmScu

Great news! Thank you Micahael.

Jøger
by jogerh
Tue, 2022-10-04, 18:09
Forum: DCMTK - General
Topic: How to populate request MessageId when deriving from DcmScu
Replies: 35
Views: 4747

Re: How to populate request MessageId when deriving from DcmScu

Hi Michael, The general issue is that it is impossible for a derived class to reimplement DcmSCU::sendMOVERequest or any of the other sendXXXRequest functions as long as the nextMessageID function is private. The specific issue, is that we want to get hold of the message ID before the C-MOVE request...
by jogerh
Tue, 2022-10-04, 15:57
Forum: DCMTK - General
Topic: How to populate request MessageId when deriving from DcmScu
Replies: 35
Views: 4747

Re: How to populate request MessageId when deriving from DcmScu

Hi again Michael, I once again stumbled across a problem caused by the private DcmSCU::nextMessageID function. DcmSCU appears to be designed with extensibility through inheritance in mind. If this is the intent, I believe that the nextMessageID must be made protected instead of private, as there are...
by jogerh
Mon, 2022-09-05, 20:41
Forum: DCMTK - General
Topic: Unable to change Implementation Class UID and Implementation Version Name
Replies: 5
Views: 489

Re: Unable to change Implementation Class UID and Implementation Version Name

Thank you Michael and Vasyl. I work in Vasyl's team. I fully agree with the principle Michael, and I too understand that it is a value for DCMTK and OFFIS to see the DCMTK identification. We will also be working within our organization to understand if it can be acceptable to use the OFFIS implement...
by jogerh
Sat, 2022-09-03, 10:29
Forum: DCMTK - Installation
Topic: Building with open SSL
Replies: 7
Views: 2508

Re: Building with open SSL

This kind of problem can show up if the dcmtkcrypto_d.lib, dcmtkcrypto_o.lib, dcmtkssl_d.lib, or dcmtkssl_o.lib are not present in the expected directory when configuring the project. I assume the heuristics for determining if OpenSsl can be found does not check presence of all libs. So, after deter...
by jogerh
Fri, 2022-09-02, 20:53
Forum: DCMTK - Installation
Topic: Can DCMTK be built relocatable on Windows with ICU and OpenSSL?
Replies: 1
Views: 305

Can DCMTK be built relocatable on Windows with ICU and OpenSSL?

I am building DCMTK (static libs) with ICU and OpenSSL on Windows with Visual Studio. To reduce build times of client software on CI/CD and developer computers, I would like to create a Nuget package (archive) that is downloaded from an artifact server. This reduces build times significantly compare...
by jogerh
Thu, 2022-06-30, 11:09
Forum: DCMTK - General
Topic: How to populate request MessageId when deriving from DcmScu
Replies: 35
Views: 4747

Re: How to populate request MessageId when deriving from DcmScu

Thank you so much! I hope for the best, and look forward to enjoying the N-SET experience.
by jogerh
Tue, 2022-06-28, 22:39
Forum: DCMTK - General
Topic: How to populate request MessageId when deriving from DcmScu
Replies: 35
Views: 4747

Re: How to populate request MessageId when deriving from DcmScu

Hi Michael, When you have time, could you please have a look at https://github.com/DCMTK/dcmtk/pull/63? It is an attempt to prevent port conflicts when using DcmSCP in unit tests. Is it correct that tests marked as EF_Slow are not run on the build servers? Maybe this could explain why the older dcmn...
by jogerh
Tue, 2022-06-28, 14:31
Forum: DCMTK - General
Topic: How to populate request MessageId when deriving from DcmScu
Replies: 35
Views: 4747

Re: How to populate request MessageId when deriving from DcmScu

Thank you Micahel, this sounds like a good explanation for the problems. I assume this is a universal challenge for automated testing of DICOM networking functionality. Maybe it could be possible to let the OS assign a free port if the DcmSCP is configured with port 0. DcmSCP seems to already have a...
by jogerh
Tue, 2022-06-28, 13:06
Forum: DCMTK - General
Topic: How to populate request MessageId when deriving from DcmScu
Replies: 35
Views: 4747

Re: How to populate request MessageId when deriving from DcmScu

Hi again Michael, I am trying to understand why the unit tests failed in your build environment. I believe that if these kind of tests fail on a build server, it is not unlikely that the code could fail also in a real life scenario. Such tests are extremely useful for detecting hard-to-reproduce bug...
by jogerh
Sun, 2022-06-26, 17:20
Forum: DCMTK - General
Topic: Forcefully closing an SCU TCP connect attempt
Replies: 2
Views: 413

Re: Forcefully closing an SCU TCP connect attempt

Thank you for the input! https://github.com/DCMTK/dcmtk/pull/62 shows a preliminary sketch which could be one way to be able to cancel ongoing association attempts while the DcmSCU is attempting to establish a TCP connection to the unreachable server. It allows waking the dulfsm.cc requestAssociatio...
by jogerh
Thu, 2022-06-23, 11:55
Forum: DCMTK - General
Topic: Change proposal: Allow per-instance configuration of DcmSCU connection timeout
Replies: 0
Views: 386

Change proposal: Allow per-instance configuration of DcmSCU connection timeout

Hi OFFIS team, I just created https://github.com/DCMTK/dcmtk/pull/61. This change makes it possible to configure the DcmSCU TCP connection timeout per instance, instead of using the global dcmConnectionTimeout parameter. In a multi-service executable, that for example supports QR, Worklist, and Stor...
by jogerh
Wed, 2022-06-08, 08:58
Forum: DCMTK - General
Topic: How to populate request MessageId when deriving from DcmScu
Replies: 35
Views: 4747

Re: How to populate request MessageId when deriving from DcmScu

Hi Michael, https://github.com/DCMTK/dcmtk/pull/57 (Extend DcmScu with support for N-SET requests) is rebased on top of master, and with some slight fixes since the previous draft. In particular, the attributeList of the DcmSCU::sendNSETRequest is made mandatory. This also goes for DcmSCU::sendNCREA...