DICOM @ OFFIS

Yes, that looks good to me. Checking for NULL is definitely a good idea. Thank you for your report and detailed analysis. It seems that no one ever used this method before - including the author of this class :? I was also surprised that nobody had found this issue until now. Probably everyone else ...

Hello, I tried to read an RT image using DRTImage::read(DcmItem *dataset). However, this fails even though I am fairly confident that the data is valid. Looking at the code, I noticed that DRTImage::read() appears to call DRTImageIOD::read() with the argument *format_.getDataset() although format_ h...

I noticed that you have created a ticket for this issue: https://support.dcmtk.org/redmine/issues/1047.

Thanks for your work!

I understand. Thank you for your efforts, I am looking forward to the next release.

Thank you for the suggestion. With this code everything works as expected! It also matches the implementation in other parts of DCMTK, e.g. DSRCodingSchemeIdentificationList::gotoNextItem() or DSRReferencedInstanceList::gotoNextItem(), so it is hopefully well tested. You are probably aware of this, ...

Hello! i've stumbled across some unexpected error messages today, when performing loops over sequences of the following kind: do { DRTROIContourSequence::Item& currentContour = rtROIContourSequence.getCurrentItem(); if (currentContour.isValid()) { // doSomething } else { std::cerr << "Error: Invalid...

After some digging I found that the problem occurs in dcmtk\config\tests\cxx11.cc. The code checks for the macro __cplusplus: #elif __cplusplus < 201103L #error "This is not a C++11 compiler" Unfortunately, MSVC doesn't set this macro correctly. From https://learn.microsoft.com/en-us/cpp/build/refer...

Hello, I managed to compile the toolkit with Visual Studio 2022. However, I noticed that CMake disabled the features of newer C++ versions: Checking whether the compiler supports C++11 Checking whether the compiler supports C++11 -- no Info: C++11 features disabled Info: C++14 features disabled Info...