DICOM @ OFFIS

For the record, Yesterday morning, 20 Feb 2012, Jörg Riesmeier added initial support for wide character filenames on Windows to the git repository of DCMTK: http://git.dcmtk.org/web?p=dcmtk.git;a=commit;h=76eb840797dc594142ca641aeaa7a3205fa0c5de We reviewed and tested the code here at LKEB, Leiden U...

Please note that when support for wide char (wchar_t) Unicode path names is added to DCMTK (on Windows platforms), it will also allow reading DICOM files from path names longer than 260 (MAX_PATH) characters. Path names of DICOM file are likely to be pretty long, for example because they may have th...

Currently I think every DCMTK user on the Windows platform needs to write some workaround, whenever Unicode filenames need to be supported. UTF8 is not supported well enough on Windows; instead, UTF16 "wide characters" need to be used to represent Unicode filenames. Here at the LKEB, we wo...

Thanks Jörg. Sounds like it makes sense for us to use a snapshot, rather than the latest version from the git repository. I still think it would be useful if you would tag each new DCMTK snapshot in your git repository. But of course, I don't want to over-ask. I'm already very happy about the git be...

When would you recommend using a snapshot , instead of taking a version of DCMTK from git.dcmtk.org? For example, could it be that the latest snapshot is tested beforehand more extensively than the latest version from git.dcmtk.org? Secondly, what particular DCMTK version (GIT revision) corresponds ...

Thanks, Jörg. I think the new option, DONT_LOAD_EXTERNAL_DICTIONARIES, will be very useful to us.

Kind regards, Niels

Thanks for adding my request to your todo list, Jörg. Indeed, your suggested change, passing OFFalse as loadExternal argument to the constructor of GlobalDcmDataDictionary, would also solve our problem. But of course, we prefer not to maintain our own locally patched version of the DCMTK sources. Ho...

dcmdata/dcdict.h (snapshot dcmtk-3.5.5_20100608) says about dcmDataDict: /** The Global DICOM Data Dictionary. * Will be created before main() starts. ... * Tries to load data dictionaries from files specified by * the DCMDICTPATH environment variable Is it really necessary to create the Global DICO...

Thanks Jörg. Your patch is exactly what I had in mind. :-) BTW, I looked at this code because I did encounter some crashes in DCMDATA_TRACE calls. However, my crashes had a different reason: I statically linked a debug build of an application to a release build of DCMTK. Both dynamically linked to t...

DcmItem::insert does in snapshot dcmtk-3.5.5_20100608, dcitem.cc: /* remove current element from list */ DcmObject *remObj = elementList->remove(); /* now the following holds: remObj == dE and elementList */ /* points to the element after the former current element. */ /* dump some information if re...

Thanks Uli! I just had a look at your code, and I think it should work fine. Cool!

BTW I'm not flying, I'm going by train!

Did anyone of you already have a look at the (potential) deadlock issue I reported on April 27? I think the fix is rather simple, as it is limited to a single DCMTK source file. Would it be helpful if we mail our modified version of dcmdata/libsrc/dccodec.cc to DICOM (at) OFFIS? Kind regards, Niels

Hi Michael, I'm glad to hear you find our WideCharInputFileStream approach interesting :-) Yes I think the approach is successful, as we're actually currently using it on Windows. And I think it would work on any other platform, because its source code doesn't use any Windows specific features. (Alt...

Thanks for your reply, Chung-Yueh. (I'm working together with Jeroen Eggermont, we both need Unicode filename support.) Unfortunately your Utf8toAnsi(utf8, len) function does not help for us. We need to read a DICOM file whose filename consists of wide characters (UTF-16). Unfortunately, both DcmFil...

Hi Jörg, Thanks for adding the OVERWRITE_COMPILER_FLAGS option (and allowing us to switch it off :D ). I just downloaded DCMTK from http://git.dcmtk.org and gave it a try. The option works well. For what it's worth, personally I would add a DCMTK specific prefix, and name it e.g., "DCMTK_OVERWR...