DICOM @ OFFIS

Luuk, thanks for the idea on the fix. I'm uneasy with quoting every argument, plus it makes enclosed escaped quotes behave different with/without the --fork option. The below code does the following. 1. Fixes the CreateProcess() security hole when the first argument is NULL as described at MSDN. htt...

I found another ~660 bytes/association leaking in ASC_receiveAssociation() very similar to the leak in DUL_ReceiveAssociationRQ(). This time it's the T_ASC_Parameters params struct getting malloc'd but never released. The fix is very similar as well. With this change I'm no longer seeing significant...

I decided it was time to get my hands dirty, so I installed Visual Studio and started digging. I'm not a coder by trade, so there may be better ways to address these leaks. 1. Mr. Colby Dillion was correct, in that there are a number of handles which need to be closed in the area he describes. I was...

I am going to go ahead and post a reply before I lose my thoughts. Once the child process has been created and you have passed all of the data that you need to pass you should be able to close hChildStdInWriteDup without any problems. This handle is never closed and that is an issue to look at. I a...

This is readily reproducible for me with the official 3.5.4 build on Windows Server 2003/XP, and on Windows 2000 Server using the build provided by Colby Dillion here: http://forum.dcmtk.org/viewtopic.php?t=715 This seems to be related to the number of associations that get forked, and not the size ...

I finally got around to fixing dul.cxx for Windows 2000 (and possibly pre-2k) multi-process mode. I hate diff files but I uploaded the old and new versions for easy diff or windiff-ing. Also there is a binary for storescp compiled using VC8. It was compiled with OpenSSL on so you will need the dcmt...

Here are the results of trying the storescp --fork option on all Win32 systems available to me. All failures exhibited the same output/behavior as described in my original post. Passes denote I was able to successfully send 2 simultaneous stores using storescu into storescp. Time permitting I will b...

Hi, on first sight this seems to be a bug, that we didn't realized so far. You never need to use "--forked-child" from commandline manually, it's only used when storescp is "forked" through the CreateProcess mechanism in dcmnet. However, using "--fork" should work. For...

If I try: storescp.exe --verbose --debug --fork --forked-child 5432 or storescp.exe --verbose --debug --forked-child 5432 I get zero output from storescp when trying to connect from storescu which still fails on the association request. As in my original post, if I remove the --forked-child and --fo...

I was happy to see that the --fork option was supposed to be working with the storescp 3.5.4 release for Win32, but I'm having some trouble with it under a system running Windows 2000 Server with SP4. To test it out, I'm only sending a single asset using storescu. Comparing the output from storescp ...