Search found 147 matches

by Shaeto
Mon, 2009-02-02, 14:41
Forum: DCMTK - General
Topic: SQ read Implicit/Explicit auto selection
Replies: 9
Views: 11424

isn't my dicom :)

well as I see it (SQ [0018, 9321]) have defined length (0058) and explicit syntax. is it bad ?
by Shaeto
Mon, 2009-02-02, 14:11
Forum: DCMTK - General
Topic: SQ read Implicit/Explicit auto selection
Replies: 9
Views: 11424

SQ read Implicit/Explicit auto selection

Is it possible to detect sequence explicit/implicit format automatically? for example - it is possible (i have sent such dicom to offis email) what dicom is implicit but one of sequences is explicit... :( at least CTN reads such files w/o any problem. latest dcmtk snapshot fails on the dataset. than...
by Shaeto
Fri, 2009-01-30, 19:10
Forum: DCMTK - General
Topic: storescp crash while receiving a corrupt dataset
Replies: 16
Views: 18835

both options work on my data

thanks
by Shaeto
Fri, 2009-01-30, 09:00
Forum: DCMTK - General
Topic: storescp crash while receiving a corrupt dataset
Replies: 16
Views: 18835

Thank you very much! testing... :)
by Shaeto
Thu, 2009-01-29, 14:22
Forum: DCMTK - General
Topic: storescp crash while receiving a corrupt dataset
Replies: 16
Views: 18835

agree! but if dcmtk finds "unknown tag" in 10-ff range and try to load it from dataset it will crash because trying to load LO with length 0xffffffff
by Shaeto
Wed, 2009-01-28, 19:42
Forum: DCMTK - General
Topic: storescp crash while receiving a corrupt dataset
Replies: 16
Views: 18835

btw if we checking private.dic

(0027,"SVISION",13) DT NewestStudy 1

definitely not a LO
etc etc alot examples in the private dictionary

(0009,"CARDIO-D.R. 1.0",40) SQ AlternateImageSequence 1

candidate for crash
by Shaeto
Tue, 2009-01-27, 17:41
Forum: DCMTK - General
Topic: storescp crash while receiving a corrupt dataset
Replies: 16
Views: 18835

yes, it will read 0xffffffff as LO (which really SQ) length and fail later on memory allocation and reading... take a look at topic starter message, stack dump will be very similar
by Shaeto
Tue, 2009-01-27, 16:03
Forum: DCMTK - General
Topic: storescp crash while receiving a corrupt dataset
Replies: 16
Views: 18835

as i see someone removed lines (0009-o-ffff,0001) UL PrivateGroupLengthToEnd 1 PRIVATE (0001-o-0007,0001) UL IllegalGroupLengthToEnd 1 ILLEGAL from dicom.dic in the latest snapshot :) what do you think about (0009-o-ffff,0010-u-00ff) LO PrivateCreator 1 PRIVATE if private creator will place SQ to th...
by Shaeto
Tue, 2009-01-27, 15:02
Forum: DCMTK - General
Topic: storescp crash while receiving a corrupt dataset
Replies: 16
Views: 18835

sent...
by Shaeto
Fri, 2009-01-23, 15:24
Forum: DCMTK - General
Topic: close resources in DcmTCPConnection destructor
Replies: 3
Views: 3518

forget about ::close - if we'll add close in destructor also need to add those changes: dcmtrans.h int getSocket() { return theSocket; } + void setSocket(int socket) { theSocket = socket; } dcmtrans.cc void DcmTCPConnection::close() { + if (getSocket()>=0) { #ifdef HAVE_WINSOCK_H - (void) shutdown(g...
by Shaeto
Fri, 2009-01-23, 15:18
Forum: DCMTK - General
Topic: close resources in DcmTCPConnection destructor
Replies: 3
Views: 3518

close resources in DcmTCPConnection destructor

i didn't find this fix in latest snapshot:

dcmnet/libsrc/dcmtrans.cc

DcmTCPConnection::~DcmTCPConnection()
{
+ close();
}

very bad leak for daemon application
by Shaeto
Wed, 2009-01-21, 15:01
Forum: DCMTK - General
Topic: storescp crash while receiving a corrupt dataset
Replies: 16
Views: 18835

i fixed similar bug by this patch: ============================================== --- dcmdata/libsrc/dcitem.cc 2005-12-08 16:41:16.000000000 +0300 +++ dcmdata/libsrc/dcitem.cc 2009-01-21 16:11:16.859375000 +0300 @@ -778,6 +778,17 @@ inStream.read(&valueLength, 4); //length field is 4 bytes wide ...