DICOM @ OFFIS

Thanks for integrating the N-CREATE code on master Michael! I am sorry about the issues with the tests, and I try to understand why the initial design did not work on your build servers. The hypothesis was that a ping client with infinite timeout would never fail to associate with the server, even i...

Ultrasound scanners typically send DICOM images to a server using a spooler mechanism that allow images to be sent in the background while the system is being used for image scanning. While the system is sending images, it may be necessary to quickly shut down the system. At the time the system is b...

I agree with you Marco. Implementing useful software with the current DcmTLSSCU is cumbersome because we almost always want to support non-TLS connections as well. DcmTLSSCU also has limited utility as an educational example, and I feel it makes it harder than necessary to learn DCMTK.

Thank you Marco! This is great news.

Thanks for very useful insights Marco. After switching to DcmSCU and using the DcmSCU::useSecureConnection() function as you suggested, there is no longer a need for this extension. The rationale for interfacing with Windows Certificate Store, is to allow end users/IT personnel to install certificat...

Thank you Marco! This sounds like a better approach. I may have been misled a bit by the design of DcmTLSScu. I'll go back to the drawing board based upon your suggestion. By the way, what is the future of DcmTLSScu? Does it require a stable API, or would it make sense to change it according to your...

Something like the example below could work. The example is based upon DcmTLSScu, but instead of inheriting from DcmSCU, the base class is templatized. Now, this mixin can be used with both DcmTLS and DcmStorageSCU. Does anyone see any issues with this design proposal? template <typename Base> class...

The DcmStorageSCU does not support TLS, and there is no equivalent in dcmtls as far as I can see. I therefore want to add support for TLS in DcmStorageSCU. Do you have any plans for adding TLS support for this base class, or do you have any design ideas? The problem as I see it is that the DCMTK des...

Thank you Marco!

Hi again Michael, Unfortunately, the alarm may not have been as false as I thought. Investigating further, it looks like BUILD_SINGLE_SHARED_LIBRARY is broken. I might be wrong again, but running the following command with a clean build tree and 'dcmtk' folder set to DCMTK-3.6.7 fails on my computer...

Thank you for a quick response Michael. My problem did not reproduce with a clean build tree. I apologise for the false alarm.

Thanks,
Jøger

The DcmTLSSCU is a nice base class for implementing SCUs with TLS. On the Windows platform it is not optimal if we want to use the Windows Certificate Store. The reason is that the current API requires exporting all certificates to the filesystem. It would be nice with a mechanism that allowed custo...

I try to build DCMTK-3.6.7 tag on https://github.com/DCMTK/dcmtk.git with openssl and icu support, with cmake cmake version 3.20.21032501-MSVC_2 for Visual Studio 2019. Unfortunately, I get an error: -- Info: STL tuple support enabled -- Info: STL system_error support enabled CMake Error at dcmtk/dc...

OFCondition DcmTLSSCU::initNetwork() seems to deadlock if addTrustedCertDir was called first. The reason seems to be a missing iterator increment. diff --git a/dcmtls/libsrc/tlsscu.cc b/dcmtls/libsrc/tlsscu.cc index ba7e913c0..86bc625a0 100644 --- a/dcmtls/libsrc/tlsscu.cc +++ b/dcmtls/libsrc/tlsscu...

Hi Michael,

Have you had time to look at the PR yet?

Thanks,
Jøger