bug in the DcmElement::writeJsonOpener

All other questions regarding DCMTK

Moderator: Moderator Team

Post Reply
Message
Author
Shaeto
Posts: 131
Joined: Tue, 2009-01-20, 17:50
Location: CA, USA
Contact:

bug in the DcmElement::writeJsonOpener

#1 Post by Shaeto » Tue, 2020-06-30, 13:32

from DICOM PS3.18 F.2.2 DICOM JSON Model Object Structure

The name of each attribute object is:
The eight character uppercase hexadecimal representation of a DICOM Tag

but in DcmElement::writeJsonOpener

/* write attribute tag */
out << ++format.indent() << "\""
<< STD_NAMESPACE hex << STD_NAMESPACE setfill('0')
<< STD_NAMESPACE setw(4) << tag.getGTag();
/* write "ggggeeee" (no comma, upper case!) */
/* for private element numbers, zero out 2 first element digits */
/* or output full element number "eeee" */
out << STD_NAMESPACE setw(4) << STD_NAMESPACE uppercase << tag.getETag() << "\":"
<< format.space() << "{" << STD_NAMESPACE dec << STD_NAMESPACE setfill(' ');
out << STD_NAMESPACE nouppercase;

so, group is lower case and element is upper case

J. Riesmeier
DCMTK Developer
Posts: 2205
Joined: Tue, 2011-05-03, 14:38
Location: Oldenburg, Germany
Contact:

Re: bug in the DcmElement::writeJsonOpener

#2 Post by J. Riesmeier » Tue, 2020-06-30, 20:26

Thank you for the report. I'll fix this issue.

Post Reply

Who is online

Users browsing this forum: Bing [Bot], Google [Bot] and 1 guest