dicom file problem

Message

jlseminara · #1 Post by **jlseminara** » Mon, 2005-05-16, 15:23

Hi everyone ... I'm back (with more problems of course)

I could developed a DICOM writer system (reads a Bitmap and generate a .dcm file) using DCMTK. At this point I can write a dicom file with its header and pixel data. The problem is when I try to read it with some dicom readers the image is shown perfectly but with others programs I get a whole white image.(I get a white image with eFilm Medical Inc. product). Here is the code. I Would really appreciate any suggestion because I'm clueless

Code: Select all

#include <diregist.h>
#include <diutils.h>
#include <dcmimage.h>
#include <dcdeftag.h>
#include <ofstdinc.h>
#include <ofstd.h>
#include <ofcond.h>
#include <dcfilefo.h>
#include <dcdatset.h>

void main(void)
{

BITMAPFILEHEADER bmpFH;
BITMAPINFOHEADER bmpIH;
unsigned char *contenidoBMP;
FILE *imagen;

if ( (imagen = fopen("1.bmp","r+")) == NULL )
{
	printf("no existe");
	exit(0);
}

fread(&bmpFH,sizeof(bmpFH),1,imagen);
fread(&bmpIH,sizeof(bmpIH),1,imagen);
fseek(imagen, bmpFH.bfOffBits, SEEK_SET);

contenidoBMP = (unsigned char *) malloc( bmpIH.biSizeImage );
fread(contenidoBMP, bmpIH.biSizeImage ,1,imagen);

DcmFileFormat fileformat;
DcmDataset *dataset = fileformat.getDataset();


/////////////////////////////////
dataset->putAndInsertString(DCM_SOPClassUID, "SOPClassUID");		
dataset->putAndInsertString(DCM_SOPInstanceUID, "SOPInstanceUID");	
/////////////////////////////////
dataset->putAndInsertString(DCM_PatientsName, "Test Dicom");
dataset->putAndInsertString(DCM_PatientID,"");
dataset->putAndInsertString(DCM_PatientsBirthDate,"");
dataset->putAndInsertString(DCM_PatientsSex,"");
//////////////////////////////////
dataset->putAndInsertString(DCM_StudyInstanceUID,"StudyInstanceUID");	
dataset->putAndInsertString(DCM_StudyDate,"");
dataset->putAndInsertString(DCM_StudyTime,"");
dataset->putAndInsertString(DCM_StudyID,"");
dataset->putAndInsertString(DCM_ReferringPhysiciansName,"");
////////////////////////////////
dataset->putAndInsertString(DCM_SeriesInstanceUID,"SeriesInstanceUID");	
dataset->putAndInsertString(DCM_SeriesNumber,"");
dataset->putAndInsertString(DCM_Modality,"Modality");
dataset->putAndInsertString(DCM_Manufacturer,"");
dataset->putAndInsertString(DCM_InstitutionName,"");
////////////////////////////////
dataset->putAndInsertString(DCM_ImageID,"ImageID");
dataset->putAndInsertString(DCM_InstanceNumber,"");
dataset->putAndInsertString(DCM_ImageType,"");                       
////////////////////////////////
dataset->putAndInsertString(DCM_BitsAllocated,"8");
dataset->putAndInsertString(DCM_BitsStored,"8");
dataset->putAndInsertString(DCM_HighBit,"0");
dataset->putAndInsertString(DCM_Rows,"576");
dataset->putAndInsertString(DCM_Columns,"768");
dataset->putAndInsertString(DCM_SamplesPerPixel,"1");
dataset->putAndInsertString(DCM_PlanarConfiguration,"1");
dataset->putAndInsertString(DCM_PixelRepresentation,"0");			
dataset->putAndInsertString(DCM_PhotometricInterpretation,"MONOCHROME2"); 
//////////////////////////////
//////////////////////////////
dataset->putAndInsertUint8Array(DCM_PixelData, contenidoBMP, bmpIH.biSizeImage);
/////////////////////////////////////////////////
dataset->putAndInsertString(DCM_WindowCenter,"");
dataset->putAndInsertString(DCM_WindowWidth,"");
//////////////// Saving the file ////////////////
OFCondition status = fileformat.saveFile("test.dcm", EXS_LittleEndianExplicit);

fclose(imagen);
}

Sincerely,
Leonardo Seminara

AndreasKnopke · #2 Post by **AndreasKnopke** » Mon, 2005-05-16, 21:19

Hello Leonardo,

the High bits value "0" seems strange. See Dicom part 3. I would suggest "7". Maybe this is the problem.
Btw. the header you create is not compliant to the standard because many mandatory items are either missing or filled with inappropriate values.

Andreas

jlseminara · #3 Post by **jlseminara** » Tue, 2005-05-17, 19:07

Thanks again for your help ... I've already solved the problem: there was indeed some mandatory tags missing and some values wrong in other tags.
If someone is interested I can share de code, it’s an easy application that generates a dicom file from a BMP.

#4 Post by **Jörg Riesmeier** » Wed, 2005-05-18, 10:46

Btw, why are you putting strings into numeric data elements? Although these values should be converted automatically by the underlying DCMTK routines it would be better to use the appropriate putAndInsertXXX() methods.

jlseminara · #5 Post by **jlseminara** » Wed, 2005-05-18, 13:11

The code I showed before is just a test, my real application is most solid, beside I did that because I wanted to know if it works ... I mean save the header as string tags and find if the file could still be processed by a dicom viewer. As I supposed the code I showed works perfectly ... now I'm trying to find when (in what cases) the way I did it wouldn't work (just for fun)
My real work now is trying to insert several images into the dicom file (a sequence)

Regards,
Leonardo Seminara
Universidad Argentina de la Empresa
www.uade.edu.ar
Buenos Aires, Argentina

bbishara · #6 Post by **bbishara** » Tue, 2005-07-05, 19:45

I am trying to write a dicom image based on a 2d array with each pixel being an 8bit unsigned #, I have no idea how ot link or use dicom and any help woudl be greatly appreciated,

I know there is a function that saves images based on a pointer in the dcmpstat , dviface.cxx file but I do not know how to call the function from my onw project or how to link anytihng, any help is appreciated

Mark

Manish · #7 Post by **Manish** » Mon, 2005-12-05, 06:59

Hello Leonardo Seminara:

I am interested in your DICOM writer system (which takes a .bmp file and generates a DICOM file).

Could you send your code to kishor.manish@gmail.com

Best Regards,
Manish

Manish · #8 Post by **Manish** » Tue, 2005-12-06, 06:48

Hello All:

In the above Leonardo's code what are the missing mandatory tags and which of mandatory tag values has been incorrectly assigned?

Actually I am trying to create a DICOM image file from a BMP file. I have taken Leonardo's code as reference. While opening the generated DICOM image file using ezDicom viewer I get "I/O Error 103".

In the above code what are the values taken by the attribute such as DCM_ImageID, DCM_InstanceNumber, DCM_ImageType.

I am new to DICOM and I am clueless to all these. Please try to resolve my queries.

#9 Post by **Marco Eichelberg** » Tue, 2005-12-06, 17:19

The most important problem with the code above is that all UIDs are invalid. For example, attribute DCM_SOPClassUID must not contain the value "DCM_SOPClassUID" but the string constant UID_SecondaryCaptureImageStorage. All other UIDs should be generated with dcmGenerateUniqueIdentifier(). There may be more problems that I have not seen, though.

walohanet · #10 Post by **walohanet** » Fri, 2005-12-09, 04:26

I am interesting in you project.Could you sent your code to me for a reference. I am assure that it is just for study
w.alohanet@gmail.com

sincerely

Manish · #11 Post by **Manish** » Wed, 2005-12-14, 11:56

Thanks for your reply. I was able to solve the bug. However I am not able to assign value to DCM_PatientsName attribute. I am getting the I/O error (while opening with ezDicom viewer) even if this attribute is assigned with NULL. If I comment this attribute I am not getting any errors while opening with ezDicom. I am not getting any error if I open with an alternate viewer(ImageJ).

alang88 · #12 Post by **alang88** » Thu, 2005-12-29, 16:56

Manish wrote:Thanks for your reply. I was able to solve the bug. However I am not able to assign value to DCM_PatientsName attribute. I am getting the I/O error (while opening with ezDicom viewer) even if this attribute is assigned with NULL. If I comment this attribute I am not getting any errors while opening with ezDicom. I am not getting any error if I open with an alternate viewer(ImageJ).

Ok, could you give me a copy of the list of mandatory items for general DICOM Image viewers!! alang88@gmail.com ，thanks！

AndreasKnopke · #13 Post by **AndreasKnopke** » Sat, 2005-12-31, 11:11

Have a look at DICOM part 3, chapter A.8, secondary capture image object definition. Here you will find all information needed.

to Manish:

I am getting the I/O error (while opening with ezDicom viewer) even if this attribute is assigned with NULL.

Do you still have this problem? If so you can send me an example image (Andreas<at>K-PACS.de) that I can check. My application (K-PACS) uses parts of the ezDicom library and might react in a similar way to your image.

regards,
Andreas

veryhotsauasge · #14 Post by **veryhotsauasge** » Sat, 2006-02-18, 16:41

Hi,

I would like to get a sample of your dicom saving source code.

please send to veryhotsausage@gmail.com. Thank you so much in advance.

Where can we get documentation on the "DCM_ " parameters? I think more information about DCM_PhotometricInterpretation and DCM_PixelData and the important ones to include would be very helpful.

#15 Post by **Marco Eichelberg** » Mon, 2006-02-20, 11:12

Where can we get documentation on the "DCM_ " parameters? I think more information about DCM_PhotometricInterpretation and DCM_PixelData and the important ones to include would be very helpful.

All DCM_ constants are just aliases for numerical DICOM tags such as (7fe0,0010). The numerical values can be lookup up in dcmtk/dcmdata/dcdeftag.h and their semantics is defined in part 3 of the DICOM standard, which is the best (and only) resource on this topic. Read the definition of the image pixel module, and unless you understand the meaning of "Information Entity", "Module", and "Type 1C Attribute", don't try to create any DICOM object

DICOM @ OFFIS

dicom file problem

dicom file problem

help

Need Code

Who is online