Exit code for DCMTK tools (dcm2xml, dsr2xml, etc.)

[nikkoara]

I got bit by assuming that any error encountered would result in a non-zero exit code. It turns out that is no the case at least for dcm2xml and dsr2xml, i.e., the following prints success:

Code: Select all

$ ./bin/dsr2xml /dev/null && echo success
F: dsr2xml: error (End of stream) reading file: /dev/null
success

Is this by design or by accident?

Thanks!

[J. Riesmeier]

By accident. Thank you for the report. I'll fix it for dcm2xml and dsr2xml.

Any other tool where you've found this (mis)behavior?

[nikkoara]

No, these are the only two I know of. I took a cursory look at the other dcmdata tools, they seem to be fine.

[J. Riesmeier]

Thanks again. Here's the commit: http://git.dcmtk.org/web?p=dcmtk.git;a= ... cc0fffd6c6