version 3.6.6 (and master)
method DcmFileFormat::writeJson does not print "," between meta and main dataset
i used simplest fix (didn't want to use stringstream)
if (dset && status.good())
{
if (metinf && metinf->card())
out << ",";
status = dset->writeJsonExt(out, format, OFFalse, OFFalse);
}
thanks!
bug in DcmFileFormat::writeJson
Moderator: Moderator Team
-
- OFFIS DICOM Team
- Posts: 1444
- Joined: Tue, 2004-11-02, 17:22
- Location: Oldenburg, Germany
- Contact:
Re: bug in DcmFileFormat::writeJson
Thank you for the bug report. I can confirm that I was able to reproduce it. I have no idea how this managed to slip through - I am fairly certain that I had fixed that error before.
-
- OFFIS DICOM Team
- Posts: 1444
- Joined: Tue, 2004-11-02, 17:22
- Location: Oldenburg, Germany
- Contact:
Re: bug in DcmFileFormat::writeJson
The bug fix has been committed now in commit #d03f56b1e and should appear in the public git in a couple of days. Here's the diff log:
Code: Select all
--- a/dcmdata/libsrc/dcfilefo.cc
+++ b/dcmdata/libsrc/dcfilefo.cc
@@ -245,10 +245,10 @@ OFCondition DcmFileFormat::writeJson(STD_NAMESPACE ostream &out,
if (metinf)
{
status = metinf->writeJsonExt(out, format, OFFalse, OFFalse);
- out << format.newline();
}
if (dset && status.good())
{
+ if (metinf && (metinf->card() > 0) && (dset->card() > 0)) out << "," << format.newline();
status = dset->writeJsonExt(out, format, OFFalse, OFFalse);
}
out << format.newline() << format.indent() << "}" << format.newline();
Who is online
Users browsing this forum: No registered users and 1 guest