Hi,
I just cloned the latest snapshot (2011-06-08) from the git repos to link against the DLL libraries (/MD), and stumbled accros a linker error (cannot find zlib...)
(Using MSVS2008.)
I solved it by adding ZLIB_LIBDIR to the link directories in ofstd/tests/CMakeList.txt and re-ran CMake:
LINK_DIRECTORIES(${ofstd_BINARY_DIR} ${ZLIB_LIBDIR})
Assuming this was the correct way to fix this: perhaps this should be included in the upcoming release.
Cheers,
Paul
${ZLIB_LIBDIR} missing in ofstd/tests/CMakeList.txt
Moderator: Moderator Team
-
- Posts: 4
- Joined: Wed, 2011-06-08, 10:03
- Location: Amsterdam
-
- DCMTK Developer
- Posts: 120
- Joined: Thu, 2009-11-26, 08:15
The short version: Whoops
The long version: Whooooooooooops
Thanks for reporting this. I originally copied the CMakeLists.txt for the tests from dcmdata/apps/CMakeLists.txt which is where this came from.
However, ofstd doesn't need zlib, so just removing ${ZLIB_LIBS} from TARGET_LINK_LIBRARIES works fine. Also, ${LIBXML_LIBDIR} isn't needed in dcmdata/tests/CMakeLists.txt.
I fixed both. The changes will be visible in git when the mirror is synchronized the next time.
Thanks for letting me know that I failed again.
The long version: Whooooooooooops
Thanks for reporting this. I originally copied the CMakeLists.txt for the tests from dcmdata/apps/CMakeLists.txt which is where this came from.
However, ofstd doesn't need zlib, so just removing ${ZLIB_LIBS} from TARGET_LINK_LIBRARIES works fine. Also, ${LIBXML_LIBDIR} isn't needed in dcmdata/tests/CMakeLists.txt.
I fixed both. The changes will be visible in git when the mirror is synchronized the next time.
Thanks for letting me know that I failed again.
-
- DCMTK Developer
- Posts: 2051
- Joined: Fri, 2004-11-05, 13:47
- Location: Oldenburg, Germany
- Contact:
-
- DCMTK Developer
- Posts: 2506
- Joined: Tue, 2011-05-03, 14:38
- Location: Oldenburg, Germany
- Contact:
Here's the commit.
Who is online
Users browsing this forum: No registered users and 1 guest