${ZLIB_LIBDIR} missing in ofstd/tests/CMakeList.txt

[Paul Groot]

Hi,

I just cloned the latest snapshot (2011-06-08) from the git repos to link against the DLL libraries (/MD), and stumbled accros a linker error (cannot find zlib...)

(Using MSVS2008.)

I solved it by adding ZLIB_LIBDIR to the link directories in ofstd/tests/CMakeList.txt and re-ran CMake:

LINK_DIRECTORIES(${ofstd_BINARY_DIR} ${ZLIB_LIBDIR})

Assuming this was the correct way to fix this: perhaps this should be included in the upcoming release.

Cheers,
Paul

[Uli Schlachter]

The short version: Whoops

The long version: Whooooooooooops

Thanks for reporting this. I originally copied the CMakeLists.txt for the tests from dcmdata/apps/CMakeLists.txt which is where this came from.
However, ofstd doesn't need zlib, so just removing ${ZLIB_LIBS} from TARGET_LINK_LIBRARIES works fine. Also, ${LIBXML_LIBDIR} isn't needed in dcmdata/tests/CMakeLists.txt.

I fixed both. The changes will be visible in git when the mirror is synchronized the next time.

Thanks for letting me know that I failed again.

[Michael Onken]

The short version: Whoops

The long version: Whooooooooooops

[J. Riesmeier]

Here's the commit.