Bug Radiopharmaceutical Radiation Dose Contstraint Checker

[Luuk]

Hi all,

In OFBool DSRRadiopharmaceuticalRadiationDoseConstraintChecker::checkContentRelationship the following code can be found:

Code: Select all

        /* row 5 of the table */
        else if ((relationshipType == RT_hasProperties) &&
            ((sourceValueType == VT_Text) || (sourceValueType == VT_Code) || (sourceValueType == VT_Num) || (targetValueType == VT_PName)))

I think it should be the following as row 5 of table A.35.14-2 has TEXT, CODE, NUM and PNAME as Source Value Type (change "(targetValueType == VT_PName)" in "(sourceValueType == VT_PName)")

Code: Select all

        /* row 5 of the table */
        else if ((relationshipType == RT_hasProperties) &&
            ((sourceValueType == VT_Text) || (sourceValueType == VT_Code) || (sourceValueType == VT_Num) || (sourceValueType == VT_PName)))

[J. Riesmeier]

You are right. Thank you for the report. I'll fix it and push the commit to the public git repository (should be visible tomorrow).

[J. Riesmeier]

Here's the commit: http://git.dcmtk.org/?p=dcmtk.git;a=com ... 8d74cefa49