Exception in DT_2_IndicatePData

All other questions regarding DCMTK

Moderator: Moderator Team

Post Reply
Message
Author
vasyl.horbatenko
Posts: 4
Joined: Mon, 2022-09-05, 09:33

Exception in DT_2_IndicatePData

#1 Post by vasyl.horbatenko »

Hi OFFIS team,

It is possible to get "read access violation" exception in DT_2_IndicatePData when server returns incorrect/malicious data in PDV length field.
The problem seems to be related to non-consistent variable types that allows to overfloat length variable when pdvLength is set by a server to a value greater then LONG_MAX + pduLength.

I created PR that addresses this issue: https://github.com/DCMTK/dcmtk/pull/87
Please have a look, and let me know what do you think.

Thanks,
Vasyl

Michael Onken
DCMTK Developer
Posts: 2067
Joined: Fri, 2004-11-05, 13:47
Location: Oldenburg, Germany
Contact:

Re: Exception in DT_2_IndicatePData

#2 Post by Michael Onken »

Hi Vasyl,

thank you for the investigation and proposed patch. I roughly looked over it a few days ago and it looks good. We will discuss the patch on Friday and I provide final feedback then.

Best regards,
Michael

Post Reply

Who is online

Users browsing this forum: Ahrefs [Bot], Bing [Bot], Google [Bot] and 1 guest