DCMTK 3.6.8 Debug storescp fail

[saltcreek]

Windows 10
DCMTK 3.6.8
DCMTK_ENABLE_STL=ON

The problem is in the functions:
void DcmTLSCiphersuiteHandler::getListOfCipherSuitesForOpenSSL(OFString& cslist, OFBool isServer) const
void DcmTLSCiphersuiteHandler::getListOfTLS13CipherSuitesForOpenSSL(OFString& cslist, OFBool isServer) const
-->qsort(&tempList[0], tempList.size(), sizeof(size_t), cipherSuiteComparison);

In debug mode, std::vector has an array out-of-bounds check. If tempList is empty, then accessing the first element (tempList[0]) fails this check and you cannot continue debugging. Need to add a check that tempList is not empty.

[Marco Eichelberg]

Thank you for the bug report. This bug has been reported before and has been fixed with commit #169030f5a in May 2024, which is publicly available via our Git server or the Github mirror.

[saltcreek]

Thank you for the bug report. This bug has been reported before and has been fixed with commit #169030f5a in May 2024, which is publicly available via our Git server or the Github mirror.

Thanks!

https://github.com/DCMTK/dcmtk/blob/451 ... cfg.cc#L56
https://github.com/DCMTK/dcmtk/blob/451 ... cfg.cc#L77
m_tLayer is not initialized and contains garbage.

the error appears here
https://github.com/DCMTK/dcmtk/blob/451 ... l.cc#L2042

[Marco Eichelberg]

Ah, that is another error. I tracked this in DCMTK issue #1141 and fixed it right away (the fix is, of course, trivial).
The commit should be visible in the public git in a few days.

[saltcreek]

Ah, that is another error. I tracked this in DCMTK issue #1141 and fixed it right away (the fix is, of course, trivial).
The commit should be visible in the public git in a few days.

Thanks!