DCMTK 3.6.8 Debug storescp fail

Compilation and installation of DCMTK

Moderator: Moderator Team

Post Reply
Message
Author
saltcreek
Posts: 5
Joined: Tue, 2023-12-12, 13:20

DCMTK 3.6.8 Debug storescp fail

#1 Post by saltcreek »

Windows 10
DCMTK 3.6.8
DCMTK_ENABLE_STL=ON

The problem is in the functions:
void DcmTLSCiphersuiteHandler::getListOfCipherSuitesForOpenSSL(OFString& cslist, OFBool isServer) const
void DcmTLSCiphersuiteHandler::getListOfTLS13CipherSuitesForOpenSSL(OFString& cslist, OFBool isServer) const
-->qsort(&tempList[0], tempList.size(), sizeof(size_t), cipherSuiteComparison);

In debug mode, std::vector has an array out-of-bounds check. If tempList is empty, then accessing the first element (tempList[0]) fails this check and you cannot continue debugging. Need to add a check that tempList is not empty.

Marco Eichelberg
OFFIS DICOM Team
OFFIS DICOM Team
Posts: 1498
Joined: Tue, 2004-11-02, 17:22
Location: Oldenburg, Germany
Contact:

Re: DCMTK 3.6.8 Debug storescp fail

#2 Post by Marco Eichelberg »

Thank you for the bug report. This bug has been reported before and has been fixed with commit #169030f5a in May 2024, which is publicly available via our Git server or the Github mirror.

saltcreek
Posts: 5
Joined: Tue, 2023-12-12, 13:20

Re: DCMTK 3.6.8 Debug storescp fail

#3 Post by saltcreek »

Marco Eichelberg wrote: Thu, 2024-10-17, 12:14 Thank you for the bug report. This bug has been reported before and has been fixed with commit #169030f5a in May 2024, which is publicly available via our Git server or the Github mirror.
Thanks!

https://github.com/DCMTK/dcmtk/blob/451 ... cfg.cc#L56
https://github.com/DCMTK/dcmtk/blob/451 ... cfg.cc#L77
m_tLayer is not initialized and contains garbage.

the error appears here
https://github.com/DCMTK/dcmtk/blob/451 ... l.cc#L2042

Marco Eichelberg
OFFIS DICOM Team
OFFIS DICOM Team
Posts: 1498
Joined: Tue, 2004-11-02, 17:22
Location: Oldenburg, Germany
Contact:

Re: DCMTK 3.6.8 Debug storescp fail

#4 Post by Marco Eichelberg »

Ah, that is another error. I tracked this in DCMTK issue #1141 and fixed it right away (the fix is, of course, trivial).
The commit should be visible in the public git in a few days.

saltcreek
Posts: 5
Joined: Tue, 2023-12-12, 13:20

Re: DCMTK 3.6.8 Debug storescp fail

#5 Post by saltcreek »

Marco Eichelberg wrote: Fri, 2024-10-18, 16:39 Ah, that is another error. I tracked this in DCMTK issue #1141 and fixed it right away (the fix is, of course, trivial).
The commit should be visible in the public git in a few days.
Thanks!

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest