Setting the SITE_UID_ROOT with CMake

[ybu]

Hi,

Dcmtk version: 3.5.3
Environment: WinXP

I am using cmake to generate the VC projects. I would like to set the SITE_UID_ROOT. I checked the faq and found this. It explains how to proceed with a Makefile but as I am using cmake...

I also saw a reference in dcmtk-3.5.3/config/docs/macros.txt. I guessed that if I add

Code: Select all

ADD_DEFINITION(-D_REENTRANT)  # just to set where I add my line ;)
ADD_DEFINITION(-DSITE_UID_ROOT="my.own.root.uid")

in the dcmtk-3.5.3/cmakelist.txt file it should work, shouldn't it?

If not, where can I set the SITE_UID_ROOT while using cmake?

Thanks,
Yannick.

[Thomas Wilkens]

Your suggestion is almost right. The following should work:

Code: Select all

ADD_DEFINITIONS(-DSITE_UID_ROOT=\\\"1.2.3.4.5\\\")

Insert this code in file dcmtk-3.5.3\CMakeLists.txt at the line you indicated.

[jmartens]

Your suggestion is almost right. The following should work:

Code: Select all

ADD_DEFINITIONS(-DSITE_UID_ROOT=\\"1.2.3.4.5\\")

Insert this code in file dcmtk-3.5.3\CMakeLists.txt at the line you indicated.

I have done so, but everytime when I run the wlmscpfs and send a C-ECHO from one of our modalities I read the following:

Code: Select all

Our Implementation Class UID:    1.2.276.0.7230010.3.0.3.5.3
Our Implementation Version Name: OFFIS_DCMTK_353
Their Implementation Class UID:    1.2.826.0.1.3680043.2.737

It looks to me that the implementation class UID is still the OFFIS UID instead of my own site UID. Am I correct? Can someone help me out?

I have the lastest version of CMAKE (2.0 - patch 6) and am trying to make dsp/dsw files for Microsoft Visual Studio 6 SP6 and am building on Win XP SP 2.

Thanks in advance!

Jonathan

[Jörg Riesmeier]

The SITE_UID_ROOT is only used for generating new UIDs. The network module always uses OFFIS_IMPLEMENTATION_CLASS_UID (which is also defined in "dcuid.h") to identify itself.

[jmartens]

Your suggestion is almost right. The following should work:

Code: Select all

ADD_DEFINITIONS(-DSITE_UID_ROOT=\\"1.2.3.4.5\\")

Insert this code in file dcmtk-3.5.3\CMakeLists.txt at the line you indicated.

I added the above line to my cmakelist.txt with my Site UID and like to build some tools with our own site uid.

Environment:
- Windows XP SP2
- DCMTK 3.5.3
- MS VC++ 6 SP 6
- CMAKE 2.0 patch 6

I ran CMAKE and now I try to compile the toolkit in MS VC++, especially dump2dcm. However when I set this project as my active project and try to execute the 'Rebuild all' option the compiler says the following:

Code: Select all

Deleting intermediate files and output files for project 'ofstd - Win32 Debug'.
Deleting intermediate files and output files for project 'dcmdata - Win32 Debug'.
Deleting intermediate files and output files for project 'dump2dcm - Win32 Debug'.
--------------------Configuration: ofstd - Win32 Debug--------------------
Building Custom Rule "D:\My Projects\dcmtk\ofstd\libsrc\CMakeLists.txt"
-- Check for working C compiler: cl -- works
-- Check for working CXX compiler: cl -- works
-- Configuring done
-- Generating done
-- Build files have been written to: D:/My Projects/dcmtk
--------------------Configuration: dcmdata - Win32 Debug--------------------
Building Custom Rule "D:\My Projects\dcmtk\dcmdata\libsrc\CMakeLists.txt"
-- Check for working C compiler: cl -- works
-- Check for working CXX compiler: cl -- works
-- Configuring done
-- Generating done
-- Build files have been written to: D:/My Projects/dcmtk
--------------------Configuration: dump2dcm - Win32 Debug--------------------
Building Custom Rule "D:\My Projects\dcmtk\dcmdata\apps\CMakeLists.txt"
-- Check for working C compiler: cl -- works
-- Check for working CXX compiler: cl -- works
-- Configuring done
-- Generating done
-- Build files have been written to: D:/My Projects/dcmtk

dump2dcm.exe - 0 error(s), 0 warning(s)

So I think erveything should be OK, however no executable is created no where in the directory tree, does anyone know what could be the problem?

I also tried to build the whole project but then the process breaks and I get the following error while the compiler is building the dcmjpeg library:

Code: Select all

--------------------Configuration: dcmcjpeg - Win32 Debug--------------------
Building Custom Rule "D:\My Projects\dcmtk\dcmjpeg\apps\CMakeLists.txt"
-- Check for working C compiler: cl -- works
-- Check for working CXX compiler: cl -- works
-- Configuring done
-- Generating done
-- Build files have been written to: D:/My Projects/dcmtk
Linking...
LINK : fatal error LNK1181: cannot open input file "dcmimgle.lib"
Error executing link.exe.

ALL_BUILD - 1 error(s), 0 warning(s)

This dcmimgle.lib file is also not created anywhere on my system.

It seems to be that only the following three lib files are generated as I can find them with the modified timestamp at the time I started compiling on my system:
- ij8.lib
- ijg12.lib
- ijg16.lib



Hopefully someone can help me out or give me a hint where to look at/start looking.

[Horst Balthasar]

We have received our UID and I wanted to use it in our application.
I have recompiled the DCMTK with:

cmake -DSITE_UID_ROOT=“1.2.826.0.1.3680043.10.1395” -DDCMTK_ENABLE_CXXX11:BOOL=ON -DDCMTK_CXX11_FLAGS=-std=c++14 -DBUILD_SHARED_LIBS=ON -DDCMTK_ENABLE_STL:BOOL=ON -DCMAKE_BUILD_TYPE=“Release” ..

Unfortunately, your UID (for the Study and Series UID) is still present in the dcm file.

Did I do something wrong during the recompilation?

We are using dcmtk version 3.6.5 on Debian 10.

Best regards
Horst

[Marco Eichelberg]

• SITE_UID_ROOT needs to be passed to the C++ compiler. You are just defining a CMake variable that never gets used. Try CXXFLAGS=-DSITE_UID_ROOT=\"1.2.826.0.1.3680043.10.1395\" cmake -DDCMTK_ENABLE_CXXX11:BOOL=ON ...
• I suspect that your UID root is too long for the UID generation algorithm in DCMTK. DCMTK may add up to 44 characters to the UID root, and your UID root is 28 characters. That is too long for the maximum of 64 characters permitted for a UID. You will either have to get a shorter UID root or revise the algorithm in dcmGenerateUniqueIdentifier().

[Horst Balthasar]

I have compiled dcmtk with your instructions and created a dcm file with our application.
When displaying the file with dcmdump, the generated UID's were all only 64 characters long.

Best regards,
Horst Balthasar

[Marco Eichelberg]

If I remember correctly, the UID generation algorithm will cut off the UID after 64 characters. In this case the UID may not be unique anymore.

[Horst Balthasar]

Thank you for your comment.

For the StudyInstance I get the UID 1.2.826.0.1.3680043.10.1395.1.2.8323329.26235.1713877985.532572
and for the series the following UID 1.2.826.0.1.3680043.10.1395.1.3.8323329.26235.1713877985.532573.

Both are 64 characters long and the last number is always incremented by 1.

I will run the test on other computers and devices and check the UID.

Unfortunately, the SOPInstance UID still contains your UID and not ours.
When saving the images I use the convert function from the Image2Dcm class. In this function the function
generateUID is called, but it uses the SITE*UID.

Do you have any idea why the wrong root UID is still used for the SOPInstanceUID ?

Best regards
Horst Balthasar